Homec4science

Fix missing inline comments issue

Authored by Jason Ge <jungejason@fb.com> on Apr 7 2012, 09:09.

Description

Fix missing inline comments issue

Summary:
some inline comments are missing in the revision page. The
reason is that the inline comments got overwritten if multiple groups of
comments are modifying the same file
(https://secure.phabricator.com/diffusion/P/browse/master/src/applications/differential/view/revisioncomment/DifferentialRevisionCommentView.php;f6748bc1907d946ffe5a0957964a5eb5fe90514f$299).

Test Plan: the comments used to be missing renders now.

Reviewers: epriestley, nh

Reviewed By: epriestley

CC: hwang, aran

Differential Revision: https://secure.phabricator.com/D2135

Details

Committed
Jason Ge <jungejason@fb.com>Apr 7 2012, 23:05
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4f5ce3d9a3ab: Update ibrary map file
Branches
Unknown
Tags
Unknown

Event Timeline

Jason Ge <jungejason@fb.com> committed rPHbbeb850d63f6: Fix missing inline comments issue (authored by Jason Ge <jungejason@fb.com>).Apr 7 2012, 23:05