Homec4science

Recommend STRICT_ALL_TABLES for every install, not just development installs

Authored by epriestley <git@epriestley.com> on Feb 23 2014, 19:59.

Description

Recommend STRICT_ALL_TABLES for every install, not just development installs

Summary:
See D8308. Enabling STRICT_ALL_TABLES prevents this entire class of error, by fataling on truncation instead of truncating. We never want truncation; it is always bad and sometimes extremely bad.

We've recommended this mode for developer installs for a long time, and some users run with it enabled, so it's very unlikely to cause any issues (I've had it enabled locally for at least 6-8 months, I think).

Test Plan:

  • Disabled mode.
  • Saw warning.
  • Enabled mode.
  • No warning.

{F117040}

Reviewers: btrahan, chad

Reviewed By: chad

CC: chad, aran, arice

Differential Revision: https://secure.phabricator.com/D8309

Details

Committed
epriestley <git@epriestley.com>Feb 23 2014, 19:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7cf0358dda11: Disallow email addresses which will overflow MySQL storage
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbbf40146fb9b: Recommend STRICT_ALL_TABLES for every install, not just development installs (authored by epriestley <git@epriestley.com>).Feb 23 2014, 19:59