Homec4science

Conpherence - fix disappearing older messages bug

Authored by Bob Trahan <btrahan@phacility.com> on May 14 2015, 20:14.

Description

Conpherence - fix disappearing older messages bug

Summary:
Fixes T8194. If you loaded a conpherence directly via a URI like /Z1 or /conpherence/1/ we didn't correctly cache the loaded transactions such that sending a message would only show that message and subsequent messages.

Fix is to build the cache properly in this case. Note this codepath is different because the server sends back more of the thread data in the initial request.

Test Plan: loaded a conpherence directly, sent messages, paged back, everything kept showing!

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8194

Differential Revision: https://secure.phabricator.com/D12844

Details

Committed
Bob Trahan <btrahan@phacility.com>May 14 2015, 20:14
Pushed
aubortJan 31 2017, 17:16
Parents
rPHdb1cd6586609: Allow setup checks to perform writes
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPHbc101e7c734b: Conpherence - fix disappearing older messages bug (authored by Bob Trahan <btrahan@phacility.com>).May 14 2015, 20:14