Homec4science

Make inline comment preview work in Diffusion

Authored by Bob Trahan <bob.trahan@gmail.com> on Jul 23 2012, 20:01.

Description

Make inline comment preview work in Diffusion

Summary: created a PhabricatorInlineCommentPreviewController so controllers in Diffusion and Differential respectively just have to handle the URI mapping and data loading like good little controllers.

Test Plan:
left inline comments on commits, deleted inline commits, submitted inline comments -- all worked well
did the same on some diffs

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1176

Differential Revision: https://secure.phabricator.com/D3034

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Jul 23 2012, 20:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPH49205f977cca: Add/update some documentation on branches and reviewable code
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPHbc29a3e8a226: Make inline comment preview work in Diffusion (authored by Bob Trahan <bob.trahan@gmail.com>).Jul 23 2012, 20:01