Homec4science

Use DifferentialCommitMessageParser and Modular Transactions to implement…

Authored by epriestley <git@epriestley.com> on Jan 30 2017, 18:51.

Description

Use DifferentialCommitMessageParser and Modular Transactions to implement "Auditors: ..."

Summary:
Ref T10978. Updates how we implement "Auditors: ..." in commit messages:

  • Use the same parsing code as everything else.
    • (Also: parse package names.)
  • Use the new transaction code.

Also, fix some UI strings.

Test Plan: Used bin/repository reparse --herald <commit> to re-run this code on commits with various messages (valid Auditors, invalid Auditors, no Auditors). Saw appropriate auditors added in the UI.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10978

Differential Revision: https://secure.phabricator.com/D17262

Details

Committed
epriestley <git@epriestley.com>Jan 31 2017, 00:23
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe16080ce7e6c: Fix typo in DifferentialRevisionCommandeerTransaction
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbc41c3f5a5b9: Use DifferentialCommitMessageParser and Modular Transactions to implement… (authored by epriestley <git@epriestley.com>).Jan 31 2017, 00:23