Homec4science

Mask typed passwords as they are entered into 'accountadmin'

Authored by epriestley <git@epriestley.com> on May 28 2011, 16:17.

Description

Mask typed passwords as they are entered into 'accountadmin'

Summary:
Currently, we echo the password as the user types it. This turns out to be a bit
of an issue in over-the-shoulder installs. Instead, disable tty echo while the
user is typing their password so nothing is shown (like how 'sudo' works).

Also show a better error message if the user chooses a duplicate email; without
testing for this we just throw a duplicate key exception when saving, which
isn't easy to understand. The other duplicate key exception is duplicate
username, which is impossible (the script updates rather than creating in this
case).

There's currently a bug where creating a user and setting their password at the
same time doesn't work. This is because we hash the PHID into the password hash,
but it's empty if the user hasn't been persisted yet. Make sure the user is
persisted before setting their password.

Finally, fix an issue where $original would have the new username set, creating
a somewhat confusing summary at the end.

I'm also going to improve the password behavior/explanation here once I add
welcome emails ("Hi Joe, epriestley created an account for you on Phabricator,
click here to login...").

Test Plan:

  • Typed a password and didn't have it echoed. I also tested this on Ubuntu

without encountering problems.

  • Chose a duplicate email, got a useful error message instead of the exception

I'd encountered earlier.

  • Created a new user with a password in one pass and logged in as that user,

this worked properly.

  • Verified summary table does not contain username for new users.

Reviewed By: jungejason
Reviewers: jungejason, tuomaspelkonen, aran
CC: moskov, jr, aran, jungejason
Differential Revision: 358

Details

Committed
epriestley <git@epriestley.com>May 28 2011, 20:52
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfff08a9894bd: Allow emails to be used for login
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbc718882491c: Mask typed passwords as they are entered into 'accountadmin' (authored by epriestley <git@epriestley.com>).May 28 2011, 20:52