Add autocomplete=off to all non-login password forms
bcdadf5947b3
Actions

Authored by epriestley <git@epriestley.com> on Aug 13 2014, 19:06.

Description

Add autocomplete=off to all non-login password forms

Summary: Fixes T5579. Modern browsers aggressively autofill credentials, but at least Firefox still behaves slightly better with this flag. Hopefully other browsers will follow suit.

Test Plan: Browsed various interfaces, verifying that login interfaces allow autocomplete while non-login interfaces do not.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5579

Differential Revision: https://secure.phabricator.com/D10253

Details

Committed

epriestley <git@epriestley.com>

Aug 13 2014, 19:06

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHa5d24609748c: Probably fix bad method call in Diffusion

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbcdadf5947b3: Add autocomplete=off to all non-login password forms (authored by epriestley <git@epriestley.com>).Aug 13 2014, 19:06

Changes (8)

				Path
	M			src/applications/auth/provider/PhabricatorLDAPAuthProvider.php
	M			src/applications/auth/provider/PhabricatorOAuthAuthProvider.php
	M			src/applications/diffusion/panel/DiffusionSetPasswordPanel.php
	M			src/applications/passphrase/controller/PassphraseCredentialEditController.php
	M			src/applications/passphrase/credentialtype/PassphraseCredentialTypePassword.php
	M			src/applications/people/controller/PhabricatorPeopleLdapController.php
	M			src/applications/settings/panel/PhabricatorSettingsPanelPassword.php
	M			src/view/form/control/AphrontFormPasswordControl.php