Homec4science

Internalize storage access for PhabricatorUserOAuthInfo

Authored by epriestley <git@epriestley.com> on Jun 14 2013, 16:00.

Description

Internalize storage access for PhabricatorUserOAuthInfo

Summary:
Ref T1536. Move all access to the underlying storage to inside the class. My plan is:

  • Migrate the table to ExternalAccount.
  • Nuke the table.
  • Make this class read from and write to ExternalAccount instead.

We can't get rid of OAuthInfo completely because Facebook still depends on it for now, via registration hooks.

Test Plan: Logged in and registered with OAuth.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1536

Differential Revision: https://secure.phabricator.com/D6171

Details

Committed
epriestley <git@epriestley.com>Jun 14 2013, 16:00
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3005811b9e13: Remove OAuth token/expiry interfaces
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbce4b7addfce: Internalize storage access for PhabricatorUserOAuthInfo (authored by epriestley <git@epriestley.com>).Jun 14 2013, 16:00