Homec4science

Mark diffusion browse result as empty directory when appropriate

Authored by Nicholas Harper <nharper@fb.com> on Aug 22 2011, 22:33.

Description

Mark diffusion browse result as empty directory when appropriate

Summary:
When selecting children of a directory, it is possible that none of its
children exist anymore even though the directory still exists. After fetching
the children but before returning them, we should check whether there are any,
and if there are no children, set the reason as empty directory.

Test Plan:
In sandbox, browsed in diffusion to a directory that exists but has no
files and saw that it has a useful message instead of a vague exception.

Reviewers: epriestley, tuomaspelkonen, jungejason

Reviewed By: tuomaspelkonen

CC: aran, tuomaspelkonen

Differential Revision: 846

Details

Committed
Nicholas Harper <nharper@fb.com>Aug 22 2011, 23:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfbef90c4c645: Added the ability to support Irc Bots that need to login into private IRC…
Branches
Unknown
Tags
Unknown

Event Timeline

Nicholas Harper <nharper@fb.com> committed rPHbd2b557b426a: Mark diffusion browse result as empty directory when appropriate (authored by Nicholas Harper <nharper@fb.com>).Aug 22 2011, 23:28