Homec4science

Don't try to implicitly subscribe users who are already subscribed

Authored by epriestley <git@epriestley.com> on Feb 23 2013, 00:54.

Description

Don't try to implicitly subscribe users who are already subscribed

Summary:
Fixes T2587. Specifically:

  • Don't try to implicitly subscribe the actor if they're already subscribed.
  • Since there are like 5 things that need to interact with subscribers, just load them once upfront for Subscribable objects.

Test Plan: Made a comment on a mock I was CC'd on without an error.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Maniphest Tasks: T2587

Differential Revision: https://secure.phabricator.com/D5091

Details

Committed
epriestley <git@epriestley.com>Feb 23 2013, 00:54
Pushed
aubortJan 31 2017, 17:16
Parents
rPHcebe6ac38771: Stylize bubble counts.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbd95121b33cc: Don't try to implicitly subscribe users who are already subscribed (authored by epriestley <git@epriestley.com>).Feb 23 2013, 00:54