Homec4science

Modernize Hovercard implementation

Authored by epriestley <git@epriestley.com> on Dec 24 2015, 20:20.

Description

Modernize Hovercard implementation

Summary:
Ref T8980. Move away from events to EngineExtensions.

This also simplifies hovercards a bit:

  • Removes tasks from revision cards.
  • Removes blockers/blocked from task cards.
  • Removes "Send Message" from user cards.

These mostly felt cluttery to me. Open to arguments to retain them. I think we can make better use of the space, though (e.g., flags, projects + board columns).

Test Plan:

  • Viewed people, task, revision, commit and project hovercards.

{F1043256}

{F1043257}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8980

Differential Revision: https://secure.phabricator.com/D14878

Details

Committed
epriestley <git@epriestley.com>Dec 24 2015, 21:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3ec07c498769: Show hovercards for most links in object property views
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbdc517485cb2: Modernize Hovercard implementation (authored by epriestley <git@epriestley.com>).Dec 24 2015, 21:18