Homec4science

Fix Excel export of date columns

Authored by epriestley <git@epriestley.com> on Apr 11 2013, 20:20.

Description

Fix Excel export of date columns

Summary:
In D4567, I made column formatting more strict, but possibly too strict. @anjali reports date columns showing internal Excel date formats ("42391.2292", etc).

@jack, if you have a chance, can you apply this and verify the behavior with @anjali? Repro steps should be:

  • View any tasks in Maniphest.
  • Click "Export to Excel".
  • Open document in Excel.
  • Date column should show dates, not integers around 42,000.

Otherwise I'll test this locally, I just need to rebuild some dependencies first which is a bit involved.

Test Plan: None yet.

Reviewers: jack, btrahan

Reviewed By: btrahan

CC: anjali, aran

Differential Revision: https://secure.phabricator.com/D5467

Details

Committed
epriestley <git@epriestley.com>Apr 11 2013, 20:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7899068cec2c: Minor Conpherence CSS tweaks
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbdef566f2e28: Fix Excel export of date columns (authored by epriestley <git@epriestley.com>).Apr 11 2013, 20:20