Homec4science

Allow Harbormaster build plans to request additional working copies

Authored by epriestley <git@epriestley.com> on Sep 29 2015, 02:57.

Description

Allow Harbormaster build plans to request additional working copies

Summary:
Ref T9123. To run upstream builds in Harbormaster/Drydock, we need to be able to check out libphutil, arcanist and phabricator next to one another.

This adds an "Also Clone: ..." field to Harbormaster working copy build steps so I can type all three repos into it and get a proper clone with everything we need.

This is somewhat upstream-centric and a bit narrow, but I don't think it's totally unreasonable, and most of the underlying stuff is relatively general.

This adds some more typechecking and improves data/type handling for custom fields, too. In particular, it prevents users from entering an invalid/restricted value in a field (for example, you can't "Also Clone" a repository you don't have permission to see).

Test Plan: Restarted build, got a Drydock resource with multiple repositories in it.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9123

Differential Revision: https://secure.phabricator.com/D14183

Details

Committed
epriestley <git@epriestley.com>Sep 29 2015, 02:57
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0438a481e113: Fix issue with "Publish/Notify" handling in repositories
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbfaa93aa9b2c: Allow Harbormaster build plans to request additional working copies (authored by epriestley <git@epriestley.com>).Sep 29 2015, 02:57