Homec4science

Make profile menu full-height

Authored by epriestley <git@epriestley.com> on Jan 14 2016, 02:29.

Description

Make profile menu full-height

Summary:
Ref T10054. This makes the profile menu full-height. It uses two pieces of dark magic:

  • calc(), which allows you to do math in CSS.
  • The vh unit, which is CSS for "viewport height".

Apparently this kind of stuff just works now? CSS got good at some point?

Test Plan:

  • Page looks correct in Safari, Chrome, Firefox.
  • Checked caniuse.com for vh and calc(), saw they're supported?

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10054

Differential Revision: https://secure.phabricator.com/D15017

Details

Committed
epriestley <git@epriestley.com>Jan 15 2016, 18:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPH468031d1fd77: Rough initial cut of profile new profile menu
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc019f76283ce: Make profile menu full-height (authored by epriestley <git@epriestley.com>).Jan 15 2016, 18:12