Homec4science

Move Differential to EditEngine comments

Authored by epriestley <git@epriestley.com> on Dec 28 2016, 18:49.

Description

Move Differential to EditEngine comments

Summary:
Ref T11114. This is a transitional change that breaks a bunch of stuff. I'll hold it until I've restored features.

This stuff works:

  • Commenting.
  • Subscribers/tags/reviewers.
  • Pinning.
  • Drafts.

This stuff does not work yet:

  • Preview of inline comments.
  • Probably submitting inlines, whatsoever.
  • Comment-area warnings like "There are failing tests."
  • All meaningful actions (accept, reject, etc).

Test Plan: Commented on a revision. Essentially nothing else works yet.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17106

Details

Committed
epriestley <git@epriestley.com>Dec 31 2016, 19:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3fedc8c299f7: Allow any EditEngine comment form to be pinned
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc05306d746d7: Move Differential to EditEngine comments (authored by epriestley <git@epriestley.com>).Dec 31 2016, 19:06