Homec4science

Show change diffs in Phriction

Authored by epriestley <git@epriestley.com> on Jul 17 2011, 20:06.

Description

Show change diffs in Phriction

Summary:
This is really rough and needs work (particularly, there's some diff code I
really need to refactor since I sort-of-copy-pasted it) but basically
functional.

Show text changes between diffs and allow users to revert to earlier versions.

Differential's line-oriented diff style isn't ideal for large blocks of text but
I'm betting this is probably good enough in most cases. We can see how bad it is
in practice and then fix it if needbe.

I added a bunch of support for "description" but didn't add the feature in this
diff, I'll either follow up or task it out since it should be a pretty
straightforward change.

Test Plan: Looked at history for several Phriction documents, clicked "previous
change" / "next change", clicked revert buttons.
Reviewed By: hsb
Reviewers: hsb, codeblock, jungejason, tuomaspelkonen
CC: aran, hsb, epriestley
Differential Revision: 687

Details

Committed
epriestley <git@epriestley.com>Jul 18 2011, 17:46
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6f388f97d959: Improve Phabricator behavior for fatal errors
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc0ae2f628973: Show change diffs in Phriction (authored by epriestley <git@epriestley.com>).Jul 18 2011, 17:46