Homec4science

Provide start screen and full registration flow on the new auth stuff

Authored by epriestley <git@epriestley.com> on Jun 16 2013, 19:15.

Description

Provide start screen and full registration flow on the new auth stuff

Summary:
Ref T1536. Code is intentionally made unreachable (see PhabricatorAuthProviderOAuthFacebook->isEnabled()).

This adds:

  • A provider-driven "start" screen (this has the list of ways you can login/register).
  • Registration actually works.
  • Facebook OAuth works.

@chad, do you have any design ideas on the start screen? I think we poked at it before, but the big issue was that there were a limitless number of providers. Today, we have:

  • Password
  • LDAP
  • Facebook
  • GitHub
  • Phabricator
  • Disqus
  • Google

We plan to add:

  • Asana
  • An arbitrary number of additional instances of Phabricator

Users want to add:

  • OpenID
  • Custom providers

And I'd like to have these at some point:

  • Stripe
  • WePay
  • Amazon
  • Bitbucket

So basically any UI for this has to accommodate 300 zillion auth options. I don't think we need to solve any UX problems here (realistically, installs enable 1-2 auth options and users don't actually face an overwhelming number of choices) but making the login forms less ugly would be nice. No combination of prebuilt elements seems to look very good for this use case.

Test Plan: Registered a new acount with Facebook.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1536

Differential Revision: https://secure.phabricator.com/D6161

Details

Committed
epriestley <git@epriestley.com>Jun 16 2013, 19:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7efee51c384d: Put some glue in between PhabricatorAuthProvider and the OAuth adapters
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc108ada7e4cb: Provide start screen and full registration flow on the new auth stuff (authored by epriestley <git@epriestley.com>).Jun 16 2013, 19:15