Homec4science

Only show text encoding note in Differential if a change has hunks

Authored by epriestley <git@epriestley.com> on Jun 29 2014, 21:42.

Description

Only show text encoding note in Differential if a change has hunks

Summary: Fixes T5503. We incorrectly render an encoding note for empty files. Only render an encoding note for text changes with at least one hunk.

Test Plan:

  • Viewed empty file, no note.
  • Viewed nonempty file with altered encoding, saw note.

Reviewers: btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T5503

Differential Revision: https://secure.phabricator.com/D9780

Details

Committed
epriestley <git@epriestley.com>Jun 29 2014, 21:42
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2ac37c696499: Add some basic documentation for Legalpad
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc1af499ed7ab: Only show text encoding note in Differential if a change has hunks (authored by epriestley <git@epriestley.com>).Jun 29 2014, 21:42