Homec4science

By default, do not save queries when executing Conduit "*.search" calls

Authored by epriestley <git@epriestley.com> on Jul 9 2016, 15:47.

Description

By default, do not save queries when executing Conduit "*.search" calls

Summary:
Fixes T11304. Prior to this change, we did an unnecessary write on every "*.search" call (this write didn't always actually write a row, since we only save unique saved queries, but still doesn't do anything useful ever, currently).

Instead, change this to not-write by default. We could add an "oh, and also I want you to do a write" option later, which would let us implement something like arc query-stuff which says "To see more results, view this URI in your browser: ...".

(It's possible to run one of these methods with an existing SavedQuery by using the key, so we still sometimes have a queryKey to return.)

Test Plan: Ran almanac.service.search, used DarkConsole to verify that no serachengine writes occurred.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11304

Differential Revision: https://secure.phabricator.com/D16263

Details

Committed
epriestley <git@epriestley.com>Jul 10 2016, 17:04
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd44a5fa93374: In Git, only use "--find-copies-harder" on small diffs
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc21be4849f8d: By default, do not save queries when executing Conduit "*.search" calls (authored by epriestley <git@epriestley.com>).Jul 10 2016, 17:04