Homec4science

Don't try to center dialogs horizontally

Authored by epriestley <git@epriestley.com> on Mar 26 2016, 20:23.

Description

Don't try to center dialogs horizontally

Summary:
Fixes T10302. I think we had fixed-width dialog containers in the past (?) but they all handle their own centering now.

This was causing them to be slightly off-center as a result, and creating the 7px issue in T10302.

Test Plan:

  • Viewed a wide dialog (task edit).
  • Viewed a narrow dialog (notification dismissal confirmation).
  • Viewed dialogs on wide/narrow screens.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10302

Differential Revision: https://secure.phabricator.com/D15529

Details

Committed
epriestley <git@epriestley.com>Mar 26 2016, 20:29
Pushed
aubortJan 31 2017, 17:16
Parents
rPH060f96079def: Fix Diffusion blame columns when disabling blame
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc286d2b441bd: Don't try to center dialogs horizontally (authored by epriestley <git@epriestley.com>).Mar 26 2016, 20:29