Homec4science

Raise a setup warning for an unparseable VCS binary version

Authored by epriestley <git@epriestley.com> on Jan 29 2015, 23:28.

Description

Raise a setup warning for an unparseable VCS binary version

Summary:
Hit this locally, with an error like:

Version <empty string> is older than 1.9, the minimum supported version.

(Where <empty string> was just the empty string, not literally the text <empty string>.)

Be more careful about parsing versions, and parse the newer string.

Test Plan: Got "unknown version" with intentionally-broken test data, then clean readout.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11558

Details

Committed
epriestley <git@epriestley.com>Jan 29 2015, 23:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4c74dc61fb16: Add Recent label to Conpherence thread list
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc2efa9065ca9: Raise a setup warning for an unparseable VCS binary version (authored by epriestley <git@epriestley.com>).Jan 29 2015, 23:28