Homec4science

Use ChangesetListView on Differential standalone view

Authored by epriestley <git@epriestley.com> on Mar 8 2015, 12:10.

Description

Use ChangesetListView on Differential standalone view

Summary:
Fixes T4452. Ref T2009. There's a hierarchy of changeset rendering power: only low-level calls, use of ChangesetDetailView, then use of ChangesetListView (a list of DetailViews).

Prior to work here, the various changeset rendering controllers got their hands dirty to varying degrees, with some using only the lowest-level rendering pipeline:

  • Phriction: no view (lowest level)
  • Diffusion: DetailView
  • Differential Changeset: DetailView
  • Differential Diff: ListView
  • Differential Revision: ListView

I brought Phriction up to use DetailView, but want to bring everything all the way up to use ListView. Each composition layer adds more features to diff browsing. In particular, this change enables "Highlight As", switching 1up vs 2up, adding inlines, etc., on the standalone view.

Test Plan:

  • Viewed a changeset standalone. Could change highlighting, switch 1up vs 2up, add and edit inlines, etc.
  • Viewed a revision; no behavioral changes.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4452, T2009

Differential Revision: https://secure.phabricator.com/D12012

Details

Committed
epriestley <git@epriestley.com>Mar 9 2015, 18:26
Pushed
aubortJan 31 2017, 17:16
Parents
rPH33a3bbbd7a3a: Put scrollbar underneath haunted comment panel
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc35cafda2c2f: Use ChangesetListView on Differential standalone view (authored by epriestley <git@epriestley.com>).Mar 9 2015, 18:26