Homec4science

Improve handle loading semantics for tokenizers

Authored by epriestley <git@epriestley.com> on Apr 2 2015, 22:42.

Description

Improve handle loading semantics for tokenizers

Summary:
Ref T7689. Fixes T7688. When there are a bunch of tokenizers with different values of the same object type (e.g. 5 tokenizers with users a, b, c, d, e) we currently issue 5 separate queries to load their handles.

Improve this behavior in the common case so we can usually batch these loads.

Test Plan:

  • In Maniphest, set the various search fields to different values.
  • Used DarkConsole to examine query plan.
  • Saw fewer queries after patch than before.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7688, T7689

Differential Revision: https://secure.phabricator.com/D12261

Details

Committed
epriestley <git@epriestley.com>Apr 2 2015, 22:42
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2ecdbbec10bf: Don't revert Conpherence page titles when updating notifications
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc39b64d963db: Improve handle loading semantics for tokenizers (authored by epriestley <git@epriestley.com>).Apr 2 2015, 22:42