Homec4science

Apply Herald subscription effects immediately

Authored by epriestley <git@epriestley.com> on Jun 8 2015, 19:50.

Description

Apply Herald subscription effects immediately

Summary:
Fixes T8464. We could incorrectly use a cached value when computing CC's.

Just load a fresh value. There are no other callers that would benefit from this cache, so it's more complicated to reload it correctly prior to publishing than to just skip it.

Also make the PHID headers unique.

Test Plan:

  • Verified that users received mail about the transactions which caused them to be added to an object.
  • Veirfied that headers no longer have redundant values.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8464

Differential Revision: https://secure.phabricator.com/D13206

Details

Committed
epriestley <git@epriestley.com>Jun 8 2015, 19:50
Pushed
aubortJan 31 2017, 17:16
Parents
rPH49570cb1c478: Fix an issue with mention transactions in Calendar
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc3b11439f281: Apply Herald subscription effects immediately (authored by epriestley <git@epriestley.com>).Jun 8 2015, 19:50