Homec4science

Don't create mentions for dependent diffs

Authored by Joshua Spence <josh@joshuaspence.com> on Jan 22 2015, 21:12.

Description

Don't create mentions for dependent diffs

Summary:
Fixes T6858. We shouldn't create mentions for dependent diffs.

NOTE: This won't fix the issue for existing revisions (which have the mentions edge), but I think that this is harmless.

Test Plan: Added Depends on Dxxx to a differential summary. Saw a josh added a dependent revision transaction, but no explicit mention.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6858

Differential Revision: https://secure.phabricator.com/D11460

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jan 22 2015, 21:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPH04ee853cecf4: Add the logger earlier in the Aphlict startup process
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHc429e4a22279: Don't create mentions for dependent diffs (authored by Joshua Spence <josh@joshuaspence.com>).Jan 22 2015, 21:12