Homec4science

Redesign Diviner

Authored by Chad Little <chad@chadsdomain.com> on Nov 1 2015, 17:56.

Description

Redesign Diviner

Summary:
This implements PHUIDocumentViewPro which should move to be the base for all documents (Phame, Phriction, Legalpad, Diviner). Overall this feels really good to me, but I'd like to roll it out into Diviner specifically first to work through the issues and then move into other apps and drop PHUIDocumentView once everything is converted. Some features are:

  • White Background, no border on page
  • Table of Contents is move to hidden menu (more space for documentation)
  • Property List sits under the document

Some design decisions above are in anticipation of Phriction v3 and Unbeta Phame, specifically commenting and maybe some cool new Remarkup text layout options for Phame.

Test Plan:
Went through tons of pages on Diviner on Desktop, Tablet, Mobile. Bounce back to Phriction to make sure DocumentView CSS changes actually look better there.

{F930518}

{F930519}

{F930520}

{F930521}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: tycho.tatitscheff, joshuaspence, Korvin

Differential Revision: https://secure.phabricator.com/D14374

Details

Committed
Chad Little <chad@chadsdomain.com>Nov 1 2015, 17:58
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2c2d1d13e378: arc liberate
Branches
Unknown
Tags
Unknown

Event Timeline

Chad Little <chad@chadsdomain.com> committed rPHc45ba3041682: Redesign Diviner (authored by Chad Little <chad@chadsdomain.com>).Nov 1 2015, 17:58