Homec4science

Improve some settings-related performance

Authored by epriestley <git@epriestley.com> on Jun 5 2016, 16:47.

Description

Improve some settings-related performance

Summary:
Ref T4103. Two small improvements:

  • Don't work as hard to validate translations. We just need to know if a translation exists, we don't need to count how many strings it has and build the entire menu.
  • Allow getUserSetting() to work on any setting without doing all the application/visibility checks. It's OK for code to look at, say, your "Conpherence Notifications" setting even if that application is not installed for you.

Test Plan: Used XHProf and saw 404 page drop from ~60ms to ~40ms locally.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4103

Differential Revision: https://secure.phabricator.com/D16046

Details

Committed
epriestley <git@epriestley.com>Jun 5 2016, 19:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7969f66dfe07: Fully modularize the "Quick Actions" menu
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc4de87a07ab0: Improve some settings-related performance (authored by epriestley <git@epriestley.com>).Jun 5 2016, 19:32