Homec4science

Make the top nav non-fixed-position

Authored by epriestley <git@epriestley.com> on Aug 31 2012, 03:58.

Description

Make the top nav non-fixed-position

Summary:
See some discussion in D1673.

  • There's a concrete (if minor) problem with this in Firefox with wrapping search.
  • People complain about how we're stealing all their pixels.
  • There isn't much of a functional purpose to it since all the operations are fairly rare.
  • This addresses the aesthetic purpose of the fixed-position nav (not making the side nav ugly) by making the side nav scroll up 44px and then stop.

Test Plan: Scrolled in desktop, tablet modes.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D3412

Details

Committed
epriestley <git@epriestley.com>Aug 31 2012, 03:58
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc4fcc8091d81: Unfinal AphrontApplicationConfiguration::willBuildRequest()
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc4ed47929c21: Make the top nav non-fixed-position (authored by epriestley <git@epriestley.com>).Aug 31 2012, 03:58