Homec4science

When publishing project transactions, load ancestor members

Authored by epriestley <git@epriestley.com> on Jan 19 2016, 18:36.

Description

When publishing project transactions, load ancestor members

Summary: Ref T10010. Fixes T10107. When we publish a transaction about a project, we perform visibility checks for many different users. We need to know all of the ancestors' members to perform these checks.

Test Plan:

  • Before patch: when updating a subproject, daemons fatal trying to publish things because they can not test visibility of parent projects.
  • After patch: daemons successfully publish subproject updates.
  • Also added a unit test.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10010, T10107

Differential Revision: https://secure.phabricator.com/D15054

Details

Committed
epriestley <git@epriestley.com>Jan 19 2016, 19:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPH99ea7082d6f3: Add a missing transaction query class for panel transactions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc51752b4aa79: When publishing project transactions, load ancestor members (authored by epriestley <git@epriestley.com>).Jan 19 2016, 19:02