Homec4science

When a user hits "Reply", then "Cancel" on an inline comment (without typing)…

Authored by epriestley <git@epriestley.com> on Aug 31 2011, 20:28.

Description

When a user hits "Reply", then "Cancel" on an inline comment (without typing), don't show "Undo"

Summary: When a user hits "Reply" on an inline comment, doesn't type anything,
and then hits "Cancel", we incorrectly store the text of the comment the user is
replying to as the "original" text, and then detect that they've changed it when
they immediately cancel. Instead, store empty string as the original text.

Test Plan:

  • Hit "Reply" and then "Cancel" on an inline comment. No undo now.
  • Hit "Reply", typed some text, and then hit "Cancel". Got an undo which

restored my text.

Reviewers: tomo, jungejason, tuomaspelkonen, aran

Reviewed By: aran

CC: aran, tomo

Differential Revision: 879

Details

Committed
epriestley <git@epriestley.com>Aug 31 2011, 21:04
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb2b677d4460f: Fix some sloppiness with definition of $slug.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc544f7801551: When a user hits "Reply", then "Cancel" on an inline comment (without typing)… (authored by epriestley <git@epriestley.com>).Aug 31 2011, 21:04