Homec4science

Give Drydock leases a resourcePHID instead of a resourceID

Authored by epriestley <git@epriestley.com> on Sep 24 2015, 13:19.

Description

Give Drydock leases a resourcePHID instead of a resourceID

Summary:
Ref T9252. Leases currently have a resourceID, but this is a bit nonstandard and generally less flexible than giving them a resourcePHID.

In particular, a resourcePHID is easier to use when rendering interfaces, since you can get handles out of a PHID.

Add a PHID column, copy over all the PHIDs that correspond to existing IDs, then drop the ID column.

Test Plan:

  • Browsed web UIs.
  • Inspected database during/after migration.
  • Grepped for resourceID.
  • Allocated a new lease with bin/drydock lease.

Reviewers: chad, hach-que

Reviewed By: hach-que

Maniphest Tasks: T9252

Differential Revision: https://secure.phabricator.com/D14151

Details

Committed
epriestley <git@epriestley.com>Sep 24 2015, 13:19
Pushed
aubortJan 31 2017, 17:16
Parents
rPH309aadc595a1: Rename Drydock Lease STATUS_EXPIRED to STATUS_DESTROYED
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc6aade439283: Give Drydock leases a resourcePHID instead of a resourceID (authored by epriestley <git@epriestley.com>).Sep 24 2015, 13:19