Homec4science

Reject SCP-style URIs with explicit protocols in Diffusion

Authored by epriestley <git@epriestley.com> on Oct 27 2013, 06:32.

Description

Reject SCP-style URIs with explicit protocols in Diffusion

Summary:
Fixes T3619. These URIs are valid:

git@domain.com:/path        (Git SCP-style implicit SSH)
ssh://git@domain.com/path   (Explicit SSH)

This URI, arrived at by adding "ssh://" to the front of an SCP-style URI, is not:

ssh://git@domain.com:/path

Detect URIs in this form and reject them. See T3619.

Test Plan:
{F75486}

Also set some valid URIs.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3619

Differential Revision: https://secure.phabricator.com/D7431

Details

Committed
epriestley <git@epriestley.com>Oct 29 2013, 23:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPH59922b78b9bc: Make Phabricator clone bare git repositories
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc749fcc192f1: Reject SCP-style URIs with explicit protocols in Diffusion (authored by epriestley <git@epriestley.com>).Oct 29 2013, 23:32