Homec4science

Users cannot attach diffs to revisions they don't own anymore.

Authored by tuomaspelkonen <tuomas.pelkonen@fb.com> on Apr 8 2011, 02:03.

Description

Users cannot attach diffs to revisions they don't own anymore.

Summary:
Users were able to accidentally update revisions they didn't own. Now
it is impossible to update a revision that belongs to someone else or
has been marked as committed.

Test Plan:
Tested that normal workflow works as previously, but after running
'arc amend', running 'arc diff' fails.

Manually changed the revision number in the git commit message and tried
to update something that belongs to Jason -> Failed.

Reviewed By: epriestley
Reviewers: epriestley
CC: jungejason, epriestley, tuomaspelkonen
Differential Revision: 112

Details

Committed
tuomaspelkonen <tuomas.pelkonen@fb.com>Apr 8 2011, 08:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPH22297b71a0f9: Close the loop on Diffusion commits posting back to Differential.
Branches
Unknown
Tags
Unknown

Event Timeline

tuomaspelkonen <tuomas.pelkonen@fb.com> committed rPHc797f9511aef: Users cannot attach diffs to revisions they don't own anymore. (authored by tuomaspelkonen <tuomas.pelkonen@fb.com>).Apr 8 2011, 08:28