Homec4science

Diffusion - move DiffusionExistsQuery to work over conduit

Authored by Bob Trahan <bob.trahan@gmail.com> on May 1 2013, 23:44.

Description

Diffusion - move DiffusionExistsQuery to work over conduit

Summary: le title. However, this also "is the first" conversion so sets the precedence for how this will all work. See comments in the code. I think this helps us keep the new code we're writing to a minimum. Wondering if the conduit end point could be more generic, and rather than have a switch statement on VCS type, one can just implement the "handleSubversion" version and have that called? Ref T2784

Test Plan: slapped an "or true" in the conditional protecting this code path. verified it worked on all 3 vcs systems, including typing in garbage and getting a 404

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2784

Differential Revision: https://secure.phabricator.com/D5803

Details

Committed
Bob Trahan <bob.trahan@gmail.com>May 1 2013, 23:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPHea78f920ddfb: Conpherence - workflow the Message link on people profiles
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPHc79d26144a01: Diffusion - move DiffusionExistsQuery to work over conduit (authored by Bob Trahan <bob.trahan@gmail.com>).May 1 2013, 23:44