Homec4science

Don't call flush() when emitting responses

Authored by epriestley <git@epriestley.com> on Mar 23 2015, 17:09.

Description

Don't call flush() when emitting responses

Summary: Fixes T7620. I don't fully understand exactly what's going on here, but we don't actually need to call flush().

Test Plan:

  • Put timing code around the echo.
  • Made a fake page that emitted a lot of data.
  • Saw the echo block proportionate to data size under curl --limit-rate ....
  • See T7620.
  • Downloaded a large file, got a reasonable progress bar and no obvious memory use issues.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: jlarouche, rbalik, epriestley

Maniphest Tasks: T7620

Differential Revision: https://secure.phabricator.com/D12127

Details

Committed
epriestley <git@epriestley.com>Mar 23 2015, 17:09
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc4d2fb087ee8: Clear floats around conpherence-edited transactions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHc7dc59f9c403: Don't call flush() when emitting responses (authored by epriestley <git@epriestley.com>).Mar 23 2015, 17:09