refactor pass 2 of N on DifferentialChangesetParser and bonus bug fix
c970f7e89c42
Actions

Authored by Bob Trahan <bob.trahan@gmail.com> on Dec 12 2012, 02:16.

Description

refactor pass 2 of N on DifferentialChangesetParser and bonus bug fix

Summary: pull out some more stuff from the TwoUp renderer that's generically useful. also clean up $xhp variable and add a get method for the $coverage. Finally, fix T2177 while I'm in here.

Test Plan: played around with Differential. Also opened things up in Firefox to verify T2177.

Reviewers: epriestley, vrana

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2009, T2177

Differential Revision: https://secure.phabricator.com/D4161

Details

Committed

Bob Trahan <bob.trahan@gmail.com>

Dec 12 2012, 02:16

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHa6aa8f746f58: Implement "USER" policy

Branches

Unknown

Tags

Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPHc970f7e89c42: refactor pass 2 of N on DifferentialChangesetParser and bonus bug fix (authored by Bob Trahan <bob.trahan@gmail.com>).Dec 12 2012, 02:16

Changes (4)

				Path
	M			src/applications/differential/parser/DifferentialChangesetParser.php
	M			src/applications/differential/render/DifferentialChangesetRenderer.php
	M			src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php
	M			src/applications/differential/view/DifferentialInlineCommentView.php