Homec4science

Replace "search scope" with selectable default behavior

Authored by epriestley <git@epriestley.com> on Feb 3 2014, 23:29.

Description

Replace "search scope" with selectable default behavior

Summary:
Fixes T4365. See discussion in D8123.

This implements the most conservative solution of approaches discussed in D8123. Basically:

  • When you search in primary search, we overwrite "query" in your default (topmost) search filter, and execute that.

This doesn't implement any of the other "sticky" stuff, where the query sticks around. Maybe we'll do that eventually, but it gets messy and could be confusing. Practically, this addresses the major use case in the wild, which is to make the menu bar search mean "Open Tasks" by default.

This also removes the old, obsolete "search scope" stuff. A long time ago, searching from within Maniphest would search tasks, etc., but this was pretty weird and confusing and is no longer used, and no one complained when we got rid of it.

Test Plan: Dragged "Open Tasks" to my top search, searched for "asdf", got "asdf in open tasks" results.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: bigo, aran

Maniphest Tasks: T4365

Differential Revision: https://secure.phabricator.com/D8135

Details

Committed
epriestley <git@epriestley.com>Feb 3 2014, 23:29
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb262ccdaff31: Use ApplicationSearch to power primary search
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHca6b9f66e198: Replace "search scope" with selectable default behavior (authored by epriestley <git@epriestley.com>).Feb 3 2014, 23:29