Homec4science

Add a flag column to Differential revision lists

Authored by Alan Huang <alanh@fb.com> on Aug 1 2012, 23:33.

Description

Add a flag column to Differential revision lists

Summary:
Put a flag icon to the left of each flagged revision in the
Differential summary tables. Flag is colored correctly and when hovered
reveals the note in a tooltip.

As epriestley specifically notes that the Flagged Revisions table should
only be shown when a user is looking at their own revisions, maybe this
ought to be limited by what controller is using this view, or something.

Test Plan:
View Differential main page. Check that flags appear
correctly if some revisions are flagged.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, avivey

Maniphest Tasks: T1557

Differential Revision: https://secure.phabricator.com/D3125

Details

Committed
Alan Huang <alanh@fb.com>Aug 1 2012, 23:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb9aff187d983: Minor, fix typeahead string casting issue with symbols. Thought I tested this.
Branches
Unknown
Tags
Unknown

Event Timeline

Alan Huang <alanh@fb.com> committed rPHca91a022fe48: Add a flag column to Differential revision lists (authored by Alan Huang <alanh@fb.com>).Aug 1 2012, 23:33