Homec4science

Fix exception in Maniphest task ID filtering

Authored by epriestley <git@epriestley.com> on Mar 3 2013, 19:56.

Description

Fix exception in Maniphest task ID filtering

Summary:
Ref T2632. When the user enters task IDs, we filter them to allow the user to write T123 or task 123 to mean 123. This filtering is latin-centric and silly, and cuases an exception when accessing, e.g,, /maniphest/view/custom/?tasks=~.

Instead of stripping a select few nondigits, strip all nondigits.

Test Plan: Hit /maniphest/view/custom/?tasks=~, no exception.

Reviewers: AnhNhan, chad, vrana

Reviewed By: chad

CC: aran

Maniphest Tasks: T2632

Differential Revision: https://secure.phabricator.com/D5193

Details

Committed
epriestley <git@epriestley.com>Mar 3 2013, 19:56
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0dde63705936: Pholio CSS touchups for inline comments.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHcb2d0adf95f2: Fix exception in Maniphest task ID filtering (authored by epriestley <git@epriestley.com>).Mar 3 2013, 19:56