Homec4science

Fixing issue when running 'arc diff'

Authored by James Rhodes <jrhodes@redpointsoftware.com.au> on May 4 2013, 13:07.

Description

Fixing issue when running 'arc diff'

Summary:
There's a crash when arc diff is running it's lint / unit test
phase which describes that this function should be public instead
of private:

Fatal error: Access level to PhabricatorPholioMockTestDataGenerator::loadPhabrictorUserPHID() must be public (as in class PhabricatorTestDataGenerator) in /srv/www/tychaia.com/phab/phabricator/src/applications/pholio/lipsum/PhabricatorPholioMockTestDataGenerator.php on line 102

Test Plan: arc diff should not crash.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5828

Details

Committed
epriestley <git@epriestley.com>May 4 2013, 13:08
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8eb85683f01d: pht for Releeph
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHcb4263620b5b: Fixing issue when running 'arc diff' (authored by James Rhodes <jrhodes@redpointsoftware.com.au>).May 4 2013, 13:08