Homec4science

Convert DifferentialRevision view to new PHUIDiffTableOfContentsListView

Authored by epriestley <git@epriestley.com> on Aug 15 2015, 20:43.

Description

Convert DifferentialRevision view to new PHUIDiffTableOfContentsListView

Summary:
Ref T2183. Introduces a new View which can (in theory) unify the Revision, Diff and Commit table of contents views.

This has the same behavior as before, but accepts slightly more general primitives and parameters and has somewhat cleaner code.

I've made one intentinoal behavior change: removing the "Open All in Editor" button. I suspect this is essentially unused, and is a pain to keep around. We can look at restoring it if anyone notices.

Test Plan: Looked at a bunch of revisions, no changes from before.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2183

Differential Revision: https://secure.phabricator.com/D13908

Details

Committed
epriestley <git@epriestley.com>Aug 15 2015, 20:43
Pushed
aubortJan 31 2017, 17:16
Parents
rPHfca716d69969: More Ponder Answer polish
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHcb912d17352c: Convert DifferentialRevision view to new PHUIDiffTableOfContentsListView (authored by epriestley <git@epriestley.com>).Aug 15 2015, 20:43