Homec4science

Attach commit diff to its revision

Authored by vrana <jakubv@fb.com> on May 22 2012, 02:55.

Description

Attach commit diff to its revision

Summary:
This attaches commit diff to its associated revision as any other diff.
The consequence is that the revision page now shows the actual commit instead of the last diff. It may be disturbing but it is desired.
Another consequence is that lint and unit results are displayed as skipped after the revision was committed. I want to fix it somehow.

My next plan is to automatically diff against the last normal diff and include the link to this diff in commit e-mail if non-empty.

Test Plan:

reparse.php

Diff against last normal diff.

Reviewers: epriestley, jungejason

Reviewed By: jungejason

CC: aran, Koolvin, jungejason

Maniphest Tasks: T201

Differential Revision: https://secure.phabricator.com/D2530

Details

Committed
vrana <jakubv@fb.com>May 23 2012, 01:08
Pushed
aubortJan 31 2017, 17:16
Parents
rPH46af8963646e: Add self-links for Differential and Maniphest
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPHccd37afab860: Attach commit diff to its revision (authored by vrana <jakubv@fb.com>).May 23 2012, 01:08