Homec4science

Fix an issue where "Browse > Select" did not work for dynamic tokenizers

Authored by epriestley <git@epriestley.com> on Apr 23 2015, 15:15.

Description

Fix an issue where "Browse > Select" did not work for dynamic tokenizers

Summary:
Ref T4100. In Herald, using the browse dialog to select a result didn't work because we'd add the token with no name value. Other things would render it elsewhere, but it would eventaully be discarded.

Instead, add it with a name value.

Test Plan: Edited a Herald rule and used Browse > Select to add a token. Saved rule. Saw token persist.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4100

Differential Revision: https://secure.phabricator.com/D12529

Details

Committed
epriestley <git@epriestley.com>Apr 23 2015, 20:49
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf69f53124ce9: Use typeaheads instead of checkbox lists for task status / priority
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHccd6770a098f: Fix an issue where "Browse > Select" did not work for dynamic tokenizers (authored by epriestley <git@epriestley.com>).Apr 23 2015, 20:49