Homec4science

Shuffle various parts of the config edit UI around

Authored by epriestley <git@epriestley.com> on Sep 3 2015, 21:15.

Description

Shuffle various parts of the config edit UI around

Summary:
Fixes T9339.

  • Don't show edit control for locked config at all.
  • Don't show a "Cancel" button either.
  • Change "Value" label to "Database Value" for non-custom config.
  • Highlight effective value.
  • Move examples under current state.
  • Tweak some formatting.

Test Plan: {F777878}

Reviewers: chad, avivey

Reviewed By: chad, avivey

Subscribers: avivey

Maniphest Tasks: T9339

Differential Revision: https://secure.phabricator.com/D14054

Details

Committed
epriestley <git@epriestley.com>Sep 3 2015, 21:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPH29399849c0ed: Scroll on overflow of property list (mobile)
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHcd2f9786bf8e: Shuffle various parts of the config edit UI around (authored by epriestley <git@epriestley.com>).Sep 3 2015, 21:15