Homec4science

Make Herald Rules sticky in X-Herald-Rules

Authored by epriestley <git@epriestley.com> on Aug 16 2011, 22:05.

Description

Make Herald Rules sticky in X-Herald-Rules

Summary:
See T354. List every rule which has ever been applied in X-Herald-Rules, not
just the ones which most recently triggered.

Also some random fixes while I was debugging this:

  • When conduit methods throw non-conduit exceptions, make sure they get

logged.

  • Trigger the Facebook "tasks" backcompat block only if we were going to fail

(this should reduce the shakniess of the transition).

  • Fix some log spew from the new field stuff.

Test Plan:

  • Created a rule (ID #3) "No Zebras" which triggers for revisions without

"zebra" in the title.

  • Created a revision without "zebra" in the title, got X-Herald-Rules: <2>,

<3>

  • Updated revision to have "zebra" in the title, verified rule did not trigger

in Herald transcript.

  • Verified X-Herald-Rules is still: <2>, <3>

Reviewed By: aran
Reviewers: aran, jungejason, tuomaspelkonen
CC: aran, epriestley
Differential Revision: 817

Details

Committed
epriestley <git@epriestley.com>Aug 17 2011, 19:38
Pushed
aubortJan 31 2017, 17:16
Parents
rPH90be65f6ece2: This write should also be unguarded, it is not vulnerable to CSRF.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHcd3a3bf759b1: Make Herald Rules sticky in X-Herald-Rules (authored by epriestley <git@epriestley.com>).Aug 17 2011, 19:38