Homec4science

Guarantee the existence of the Phabricator access log

Authored by epriestley <git@epriestley.com> on Apr 2 2013, 18:53.

Description

Guarantee the existence of the Phabricator access log

Summary:
We have a fair number of conditionals on the existence of the access log. Instead, always build it and just don't write it if the user doesn't want a version on disk.

Also, formalize logged-in user PHID (avoids object existence juggling) in the access log and move microseconds-since-startup to PhabricatorStartup (simplifies index.php).

Depends on D5532. Fixes T2860. Ref T2870.

Test Plan: Disabled access log, verified XHProf writes occurred correctly.

Reviewers: btrahan, chad

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2860, T2870

Differential Revision: https://secure.phabricator.com/D5533

Details

Committed
epriestley <git@epriestley.com>Apr 2 2013, 18:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPH0f9bfa3bfdc3: Fix XHProf index page
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHcde1416446f6: Guarantee the existence of the Phabricator access log (authored by epriestley <git@epriestley.com>).Apr 2 2013, 18:53