Homec4science

When a custom logo is configured but has a restrictive visibility policy, fall…

Authored by epriestley <git@epriestley.com> on Dec 9 2016, 13:15.

Description

When a custom logo is configured but has a restrictive visibility policy, fall back to the default logo

Summary: Fixes T11982. Currently, configuring a custom logo and then setting the policy restrictively locks off the whole install.

Test Plan:

  • Configured ui.logo.
  • Searched for the file PHID in global search to find the underlying file.
  • Set the policy to something restrictive ("only me").
  • Purged cache (bin/cache purge --purge-all).
  • Restarted webserver to nuke APC.
  • Loaded a page as a different user.
  • Before change: policy exception while trying to load the logo.
  • After change: fallback to default logo.
  • Loaded page as user who can see the logo, got custom logo.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11982

Differential Revision: https://secure.phabricator.com/D17011

Details

Committed
epriestley <git@epriestley.com>Dec 9 2016, 16:50
Pushed
aubortJan 31 2017, 17:16
Parents
rPHffdc082852fe: Add a wide range of HTTP-request-based setup checks
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHcde37acb4bd4: When a custom logo is configured but has a restrictive visibility policy, fall… (authored by epriestley <git@epriestley.com>).Dec 9 2016, 16:50