Make all bin/* scripts locate their workflows dynamically
ce78bf1de4e5
Actions

Authored by epriestley <git@epriestley.com> on Dec 27 2013, 22:15.

Description

Make all bin/* scripts locate their workflows dynamically

Summary:
Ref T2015. Not directly related to Drydock, but I bumped into this. All these scripts currently enumerate their workflows explicitly.

Instead, use PhutilSymbolLoader to automatically discover workflows. This reduces code duplication and errors (see all the bad extends this diff fixes) and lets third parties add new workflows (not clearly valuable?).

Test Plan: Ran bin/x help for each modified script.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2015

Differential Revision: https://secure.phabricator.com/D7840

Details

Committed

epriestley <git@epriestley.com>

Dec 27 2013, 22:15

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHe397103bf211: Extend all "ManagementWorkflow" classes from a base class

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHce78bf1de4e5: Make all bin/* scripts locate their workflows dynamically (authored by epriestley <git@epriestley.com>).Dec 27 2013, 22:15

Changes (24)

				Path
	M			scripts/diviner/diviner.php
	P			scripts/drydock/drydock_control.php Copied from scripts/setup/manage_harbormaster.php
	P			scripts/fact/manage_facts.php Copied from scripts/setup/manage_harbormaster.php
	P			scripts/files/manage_files.php Copied from scripts/setup/manage_harbormaster.php
	M			scripts/lipsum/manage_lipsum.php
	P			scripts/mail/manage_mail.php Copied from scripts/setup/manage_harbormaster.php
	P			scripts/repository/manage_repositories.php Copied from scripts/setup/manage_harbormaster.php
	M			scripts/search/manage_search.php
	M			scripts/setup/manage_audit.php
	P			scripts/setup/manage_auth.php Copied from scripts/setup/manage_harbormaster.php
	P			scripts/setup/manage_config.php Copied from scripts/setup/manage_harbormaster.php
	M			scripts/setup/manage_feed.php
	P			scripts/setup/manage_harbormaster.php Copied to multiple locations: scripts/drydock/drydock_control.php scripts/fact/manage_facts.php scripts/files/manage_files.php scripts/mail/manage_mail.php scripts/repository/manage_repositories.php scripts/setup/manage_auth.php scripts/setup/manage_config.php
	M			scripts/setup/manage_policy.php
	M			scripts/sql/manage_storage.php
	M			src/__phutil_library_map__.php
	M			src/applications/cache/management/PhabricatorCacheManagementPurgeWorkflow.php
	M			src/applications/metamta/management/PhabricatorMailManagementListInboundWorkflow.php
	M			src/applications/metamta/management/PhabricatorMailManagementListOutboundWorkflow.php
	M			src/applications/metamta/management/PhabricatorMailManagementReceiveTestWorkflow.php
	M			src/applications/metamta/management/PhabricatorMailManagementResendWorkflow.php
	M			src/applications/metamta/management/PhabricatorMailManagementSendTestWorkflow.php
	M			src/applications/metamta/management/PhabricatorMailManagementShowInboundWorkflow.php
	M			src/applications/metamta/management/PhabricatorMailManagementShowOutboundWorkflow.php