Homec4science

Don't show error operations after a successful land operation

Authored by epriestley <git@epriestley.com> on Oct 26 2015, 22:27.

Description

Don't show error operations after a successful land operation

Summary:
Ref T182. When viewing a revision, if there are several error operations and then a success operation, we currently show the last error. This is misleading.

Instead, don't show anything if there's a success (this may require tuning eventually if you can land multiple times onto different branches or whatever, but should be reasonable for now).

Also make the table a little nicer, particularly for merge failure output.

Test Plan: {F910385}

Reviewers: chad, Mnkras

Reviewed By: Mnkras

Maniphest Tasks: T182

Differential Revision: https://secure.phabricator.com/D14348

Details

Committed
epriestley <autocommitter@example.com>Oct 26 2015, 22:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6e7ceb996bb3: Set a property so that unit tests run on PHP7
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <autocommitter@example.com> committed rPHcea633f698da: Don't show error operations after a successful land operation (authored by epriestley <git@epriestley.com>).Oct 26 2015, 22:27