Homec4science

Move invalid session error to login page

Authored by vrana <jakubv@fb.com> on Apr 14 2012, 07:29.

Description

Move invalid session error to login page

Summary:
With invalid session (which happens for me when I change production and dev db but can of course happen in other cases), Phabricator displays an ugly unhandled exception dialog suggesting to logging in again.
But there's no login dialog on that page.

This also changes how users with invalid session are treated on pages not requiring logging.
Previously, an exception was thrown on them. Now they are treated as unlogged users.

Test Plan: Corrupt session, go to /, login.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran

Differential Revision: https://secure.phabricator.com/D2236

Details

Committed
vrana <jakubv@fb.com>Apr 15 2012, 07:19
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd17be1d824e5: Fix SVN commit change parser for files moved from deleted directory
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPHced84470a976: Move invalid session error to login page (authored by vrana <jakubv@fb.com>).Apr 15 2012, 07:19